[ENGMP-216] add oom cooldown to block rollout #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Jin <yi.jin@databricks.com>
jnyi
force-pushed
the
ENGMP-216-safe-rollout
branch
from
23ea0e6 to
c974650
Compare
Signed-off-by: Yi Jin <yi.jin@databricks.com>
hczhu-db
approved these changes
Jun 11, 2025
Signed-off-by: Yi Jin <yi.jin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today rollout operator determines to continue the release when other statefulset replications' pods are ready/running required for write quorum.
However it is possible some statefulsets were running hot and had OOM kills recently. This PR will block rollout if and only if other replications detect recent OOM Kills. This will make release safer in an already hot cluster while not blocking current statefulset.
Added multiple unit tests.